Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save color configuration in a thread local variable #426

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

bjacotg
Copy link
Collaborator

@bjacotg bjacotg commented Jul 12, 2024

This has three advantages:

  • Avoid recomputing this configuration multiple times. Thread local variables are instantiated lazily, so it is only a positive.
  • Remove dependency on serial_test
  • Remove usage in unit tests of std::env::set_var and std::env::remove_var, which will eventually become unsafe rust#27970.

@copybara-service copybara-service bot merged commit 01e054f into main Jul 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant