Use proper feature test macro to test if library supports char8_t #3183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference is here: https://en.cppreference.com/w/cpp/feature_test This PR fixes the weird case of compiling with `clang++ -std=c++17 -fchar8_t`
Contributor
Author
|
@EricWF, could you, please, take a look? |
CJ-Johnson
added a commit
that referenced
this pull request
Jun 17, 2021
PiperOrigin-RevId: 378915968
georgthegreat
added a commit
to georgthegreat/googletest
that referenced
this pull request
Jul 21, 2022
Some of the #ifdefs were missed in original PR. Should be fixed now.
Merged
gaspardpetit
pushed a commit
to eidosmontreal/googletest
that referenced
this pull request
Feb 24, 2023
Some of the #ifdefs were missed in original PR. Should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference is here: https://en.cppreference.com/w/cpp/feature_test
This PR fixes the weird case of compiling with
clang++ -std=c++17 -fchar8_t