Skip to content

Conversation

@venik
Copy link
Contributor

@venik venik commented Jul 1, 2022

Changes:

  1. Unused parameter was removed from ::testing::internal::GetCurrentOsStackTraceExceptTop. This code was reworked more than a decade ago aaebfcd.
  2. In a couple of tests return type was replaced with const auto&. It's a little bit more convenient because uncouples the implementation of the tests from the return type of ::GetInstance().
make test
Running tests...
...
100% tests passed, 0 tests failed out of 63

Total Test time (real) =   7.67 sec

Copy link
Contributor Author

@venik venik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a partial split from #3852. It cleans up code a little bit without the change to the ::GetInstance() implementation.

@dinord dinord self-assigned this Jul 11, 2022
@copybara-service copybara-service bot merged commit bea621c into google:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants