pcap: use C.struct, not _Ctype_struct #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future Go 1.12 version of the cgo tool will issue an error for Go code that uses names like _Ctype_struct_S, as that is in the namespace that cgo uses for its own generated code. Change this code to use the supported form C.struct_S, so that it builds with the future 1.12.
|
Looks good. Thanks |
|
Thanks, Ian :) |
|
@notti when can I expect this in the release? is there any plan for a new release nearby? |
|
@gconnel Was just about to ask that :) |
|
@mkumatag Just tagged a new release |
bboreham
added a commit
to weaveworks/scope
that referenced
this pull request
May 15, 2019
To pick up a fix google/gopacket#589 for Go 1.12
bboreham
added a commit
to weaveworks/scope
that referenced
this pull request
Sep 20, 2019
To pick up a fix google/gopacket#589 for Go 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future Go 1.12 version of the cgo tool will issue an error for Go
code that uses names like _Ctype_struct_S, as that is in the namespace
that cgo uses for its own generated code. Change this code to use the
supported form C.struct_S, so that it builds with the future 1.12.