Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unix.Timespec/Timeval member type various #627

Merged
merged 1 commit into from
May 6, 2019
Merged

Conversation

boypt
Copy link
Contributor

@boypt boypt commented Mar 28, 2019

unix.Timespec/unix.Timeval members are int32 in 32-bit arch

But time.Unix always accept int64 arguments. Type casting is needed.

`unix.Timespec`/`unix.Timeval` members are `int32` in 32-bit arch
 - https://github.com/golang/sys/blob/master/unix/ztypes_linux_arm.go#L24
 - https://github.com/golang/sys/blob/master/unix/ztypes_linux_386.go#L24

But `time.Unix` always accept int64 arguments. Type casting is needed.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@notti notti mentioned this pull request Apr 8, 2019
@notti
Copy link
Collaborator

notti commented May 5, 2019

@boypt Any chance on signing the CLA?

@boypt
Copy link
Contributor Author

boypt commented May 6, 2019

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@boypt
Copy link
Contributor Author

boypt commented May 6, 2019

@notti CLA signed, tks

@notti notti merged commit 0c5150f into google:master May 6, 2019
@notti
Copy link
Collaborator

notti commented May 6, 2019

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants