Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third party dependencies should have a different group name #45

Closed
paulthomson opened this issue Oct 5, 2018 · 0 comments
Closed

Third party dependencies should have a different group name #45

paulthomson opened this issue Oct 5, 2018 · 0 comments

Comments

@paulthomson
Copy link
Collaborator

E.g. com.graphicsfuzz.thirdparty.thrift-js
And the script that checks for dependency information should ignore com.graphicsfuzz dependencies, unless they are third party.
paulthomson added a commit that referenced this issue Oct 18, 2018
@paulthomson
Fixes #45.
33d7346 
Third party internal maven projects now use group com.graphicsfuzz.thirdparty. The group com.graphicsfuzz is now ignored by the licenses.py script so we don't need to provide license information for our own maven projects.
@malayaku malayaku mentioned this issue Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulthomson