Merge pull request #279 from google/devoncarew_linelength

add a linelength arg to Dartfmt

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Add `sourceDirs` and `existingSourceDirs` to return the projects top-level
   directories usually containing Dart source files.
 - Deprecate the `Tests` class (in favor of `TestRunner`)
+- Add `lineLength` as an optional argument to `DartFmt.format`
 
 ## 0.7.1+3 (2015/5/24)
 - Fix bug with Dart.run/runAsync. Args were swapped.

lib/grinder_sdk.dart

@@ -370,20 +370,25 @@ class Analyzer {
 class DartFmt {
   /// Run the `dartfmt` command with the `--overwrite` option. Format a file, a
   /// directory or a list of files or directories in place.
-  static void format(fileOrPath) {
-    _run('--overwrite', coerceToPathList(fileOrPath));
+  static void format(fileOrPath, {int lineLength}) {
+    _run('--overwrite', coerceToPathList(fileOrPath), lineLength: lineLength);
   }
 
   /// Run the `dartfmt` command with the `--dry-run` option. Return `true` if
   /// any files would be changed by running the formatter.
-  static bool dryRun(fileOrPath) {
-    String results = _run('--dry-run', coerceToPathList(fileOrPath));
+  static bool dryRun(fileOrPath, {int lineLength}) {
+    String results = _run('--dry-run', coerceToPathList(fileOrPath),
+        lineLength: lineLength);
     return results.trim().isNotEmpty;
   }
 
   static String _run(String option, List<String> targets,
-      {bool quiet: false}) => run_lib.run(_sdkBin('dartfmt'),
-          quiet: quiet, arguments: [option]..addAll(targets));
+      {bool quiet: false, int lineLength}) {
+    List args = [option];
+    if (lineLength != null) args.add('--line-length=${lineLength}');
+    args.addAll(targets);
+    return run_lib.run(_sdkBin('dartfmt'), quiet: quiet, arguments: args);
+  }
 }
 
 /// Access the `pub global` commands.

lib/src/run.dart

@@ -12,7 +12,7 @@ import 'dart:convert';
 
 /// Synchronously run an [executable].
 ///
-/// If [quiet] is false, [log]s the stdout.  The stderr is always logged.
+/// If [quiet] is false, [log]s the stdout. The stderr is always logged.
 ///
 /// Returns the stdout.
 ///
@@ -52,7 +52,7 @@ String run(String executable, {List<String> arguments: const [],
 
 /// Synchronously run an [executable].
 ///
-/// If [quiet] is false, [log]s the stdout.  The stderr is always logged.
+/// If [quiet] is false, [log]s the stdout. The stderr is always logged.
 ///
 /// Returns the stdout.
 ///