add a files param to TestRunner.test #246
Conversation
| return _test.runAsync(_buildArgs( | ||
| files: files, |
There was a problem hiding this comment.
An optional positional parameter would be more consistent with the command-line test runner and with Dartfmt and Analyzer, but we'd have to wait until this DEP until we could actually make it optional. If we keep it named, maybe paths is more self-documenting that you can use a directory path and not just file paths?
There was a problem hiding this comment.
Totally agree re: the optional positional parameter; would have preferred to have something like that available. I think the primary use-case will be files however; would prefer to keep it as is.
add a files param to TestRunner.test
| @@ -305,7 +306,7 @@ class Analyzer { | |||
| List args = []; | |||
| if (packageRoot != null) args.add('--package-root=${packageRoot.path}'); | |||
| if (fatalWarnings) args.add('--fatal-warnings'); | |||
| args.addAll(_coerceToPathList(fileOrPaths)); | |||
| args.addAll(coerceToPathList(fileOrPaths)); | |||
There was a problem hiding this comment.
It's a bit weird that here are fileOrPaths, files (line 320), fileOrPath (line 335) for the same kind of argument. Also the doc-comments are written differently.
filesparam toTestRunner.test