Skip to content

Commit

Permalink
Fix #2334 (#2337)
Browse files Browse the repository at this point in the history
* Fix #2334

This commit replaces the `NumberFormatException` with `MalformedJsonException` in the `JsonReader#readEscapeCharacter()` and also fixes the tests.

* Removes white-space
  • Loading branch information
MaicolAntali authored Mar 6, 2023
1 parent 0adcdc8 commit 85ebaf7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions gson/src/main/java/com/google/gson/stream/JsonReader.java
Original file line number Diff line number Diff line change
Expand Up @@ -1587,7 +1587,7 @@ public String getPath() {
* been read. This supports both unicode escapes "u000A" and two-character
* escapes "\n".
*
* @throws NumberFormatException if any unicode escape sequences are
* @throws MalformedJsonException if any unicode escape sequences are
* malformed.
*/
@SuppressWarnings("fallthrough")
Expand All @@ -1614,7 +1614,7 @@ private char readEscapeCharacter() throws IOException {
} else if (c >= 'A' && c <= 'F') {
result += (c - 'A' + 10);
} else {
throw new NumberFormatException("\\u" + new String(buffer, pos, 4));
throw new MalformedJsonException("\\u" + new String(buffer, pos, 4));
}
}
pos += 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ public void testUnescapingInvalidCharacters() throws IOException {
try {
reader.nextString();
fail();
} catch (NumberFormatException expected) {
} catch (MalformedJsonException expected) {
}
}

Expand Down

0 comments on commit 85ebaf7

Please sign in to comment.