Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As cqjason describes in issue #1592, the behavior of
JsonTreeWriter.name()
is inconsistent with the method it overrides in its parent JsonWriter. When callingJsonWriter.name(null)
, a NullPointerException is thrown, while callingJsonTreeWriter.name(null)
does not throw an exception, leading to a potentially misleading IllegalStateException when callingJsonTreeWriter.value()
later in execution.To resolve this, I just copied the null check from lines 385-387 of JsonWriter.
Edit: I had made a few style changes to the design document on this fork, but reverted them in order to keep the changes issue-related.