Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GsonTest.testGetAdapter_Concurrency #2177

Merged

Conversation

Marcono1234
Copy link
Collaborator

Follow-up for #2153

Makes the test implementation more reliable to prevent flaws in the test setup causing spurious test success. For example the previous test setup would not have noticed when the default Number adapter was returned instead of the custom adapter instance.

Sorry that I did not include that in the previous pull request.

Makes the test implementation more reliable to prevent flaws in the test
setup causing spurious test success.
@eamonnmcmanus eamonnmcmanus merged commit 18b9ba4 into google:master Aug 19, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/GsonTest-improvements branch August 19, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants