Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency on Error Prone Annotations non-optional #2346

Conversation

Marcono1234
Copy link
Collaborator

Purpose

Avoid problems for users which could occur due to dependency being optional

Description

See discussion starting at #2320 (comment)
Making the dependency non-optional seems to be safer and avoids confusing warnings for users.

Checklist

  • New code follows the Google Java Style Guide
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

@Marcono1234 Marcono1234 force-pushed the marcono1234/error-prone-annotations-required branch from d07f63c to 6252a4a Compare March 18, 2023 23:03
@eamonnmcmanus
Copy link
Member

Thanks! As discussed previously, this does seem to be the right thing to do. As mentioned in that discussion, we might later decide to have Gson-private versions of the annotations we use (@Keep and @InlineMe), since their analysers only look at the simple name of the annotation. But the overhead of an annotation definition is pretty small so it's probably not worth doing that.

@eamonnmcmanus eamonnmcmanus merged commit 6eddbf3 into google:master Mar 19, 2023
@Marcono1234 Marcono1234 deleted the marcono1234/error-prone-annotations-required branch March 19, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants