Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per test timeout #94

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

Momcilo42
Copy link
Contributor

This allows for a test to timeout when hanging.
It's also more useful than the general timeout option as this shows if more than one test can timeout.

@google-cla
Copy link

google-cla bot commented Jul 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Momcilo42 Momcilo42 force-pushed the per_test_timeout_feature branch from c9cf858 to c70dcc5 Compare July 31, 2023 12:12
This allows for a test to timeout when hanging.
It's also more useful than the general timeout option as this shows if
more than one test can timeout.
@Momcilo42 Momcilo42 force-pushed the per_test_timeout_feature branch from c70dcc5 to 312e7e6 Compare July 31, 2023 12:21
@Momcilo42
Copy link
Contributor Author

@pbos Can you take a look?

@pbos
Copy link
Collaborator

pbos commented Aug 22, 2023

Hi, sorry I'm out on parental leave until ~November. I'll take a look then.

@jleconte2 do you know off the top of your head how WebRTC deals with test timeouts? I wouldn't want us to duplicate functionality if we already offer something similar.

@jleconte2
Copy link
Contributor

WebRTC runs gtest_parallel under LUCI infrastructure which provides its own timeouts management.
It currently does not use the timeouts provided by gtest_parallel.

@Momcilo42
Copy link
Contributor Author

@pbos Can you take a look now?

@pbos pbos merged commit 96f4f90 into google:master Jan 16, 2024
@pbos
Copy link
Collaborator

pbos commented Jan 16, 2024

It looks like upstream isn't interested in adding per-test-timeout (since gtest runners like blaze and cmake support timeout) and I think gtest-parallel falls within the scope of being a gtest runner. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants