Update test for iOS 17 (and related OSes) NSURL changes. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+[NSURL URLWithString:] changed with iOS 17 (and the related OSes), it used to always fail (return nil) for some invalid urls. The test depended on that behavior. Now NSURL will escape the characters that would have failed things before. Since the test is calling an internal helper it will only ever see urls that return in redirect responses from servers. So there is no real way a server should ever return something matched the test case. Rather that change the logic in the handling, revise the test to explicitly test the nil case that was desired. If there ever is a concern that a server might get some other redirect from "secure" to "insecure", then we can revise the logic at that time. (it would only be around protocol changes) Fixes google#368
thomasvl
force-pushed
the
ios_17_nsurl_changes
branch
from
6abe71a to
5b24c93
Compare
dmaclach
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+[NSURL URLWithString:] changed with iOS 17 (and the related OSes), it used to always fail (return nil) for some invalid urls. The test depended on that behavior. Now NSURL will escape the characters that would have failed things before.
Since the test is calling an internal helper it will only ever see urls that return in redirect responses from servers. So there is no real way a server should ever return something matched the test case. Rather that change the logic in the handling, revise the test to explicitly test the nil case that was desired.
If there ever is a concern that a server might get some other redirect from "secure" to "insecure", then we can revise the logic at that time. (it would only be around protocol changes)