Correct the modular header support.

[thomasvl]

Looks like the suggested fix in #384 was likely wrong, swap to what seems to be the more correct directive.

Fixes #389

[thomasvl]

@paulb777 @mdmathias @jmagman this seems correct instead?

[paulb777]

Seems correct to me, but would be good to get a confirmation that it addresses the use case that led to original change. @jmagman @mdmathias

[thomasvl]

Seems correct to me, but would be good to get a confirmation that it addresses the use case that led to original change. @jmagman @mdmathias

Do either of you have a way to confirm this fixes this for your original cases also?

[mdmathias]

I'm catching up on this...

Is this issue simply that the xcconfig setting we recently added to our .podspecs is older syntax that should be updated to pod_target_xcconfig? Doesn't seem like there is an xcconfig setting in the podspec syntax...

In any case, I tried replicating this warning in one of Google Sign-In iOS's sample projects and did not see this warning.

Here are the pods that the sample pulls in (which includes the versions of AppAuth and gtm-session-fetcher with the xcconfig setting in their respective .podspecs):

PODS:
  - AppAuth (1.7.4):
    - AppAuth/Core (= 1.7.4)
    - AppAuth/ExternalUserAgent (= 1.7.4)
  - AppAuth/Core (1.7.4)
  - AppAuth/ExternalUserAgent (1.7.4):
    - AppAuth/Core
  - AppCheckCore (10.18.2):
    - GoogleUtilities/Environment (~> 7.11)
    - PromisesObjC (~> 2.3)
  - GoogleSignIn (7.1.0-fac-beta-1.1.0):
    - AppAuth (< 2.0, >= 1.7.3)
    - AppCheckCore (~> 10.18)
    - GTMAppAuth (< 5.0, >= 4.1.1)
    - GTMSessionFetcher/Core (~> 3.3)
  - GoogleSignIn/unit (7.1.0-fac-beta-1.1.0):
    - AppAuth (< 2.0, >= 1.7.3)
    - AppCheckCore (~> 10.18)
    - GoogleUtilities/MethodSwizzler (~> 7.13)
    - GoogleUtilities/SwizzlerTestHelpers (~> 7.13)
    - GTMAppAuth (< 5.0, >= 4.1.1)
    - GTMSessionFetcher/Core (~> 3.3)
    - OCMock
  - GoogleSignInSwiftSupport (7.1.0):
    - GoogleSignIn (~> 7.1.0-fac-beta-1.1.0)
  - GoogleSignInSwiftSupport/unit (7.1.0):
    - GoogleSignIn (~> 7.1.0-fac-beta-1.1.0)
  - GoogleUtilities/Environment (7.13.0):
    - GoogleUtilities/Privacy
    - PromisesObjC (< 3.0, >= 1.2)
  - GoogleUtilities/Logger (7.13.0):
    - GoogleUtilities/Environment
    - GoogleUtilities/Privacy
  - GoogleUtilities/MethodSwizzler (7.13.0):
    - GoogleUtilities/Logger
    - GoogleUtilities/Privacy
  - GoogleUtilities/Privacy (7.13.0)
  - GoogleUtilities/SwizzlerTestHelpers (7.13.0):
    - GoogleUtilities/MethodSwizzler
  - GTMAppAuth (4.1.1):
    - AppAuth/Core (~> 1.7)
    - GTMSessionFetcher/Core (< 4.0, >= 3.3)
  - GTMSessionFetcher/Core (3.4.0)
  - OCMock (3.9.3)
  - PromisesObjC (2.4.0)

DEPENDENCIES:
  - GoogleSignIn (from `../../../`)
  - GoogleSignIn/unit (from `../../../`)
  - GoogleSignInSwiftSupport (from `../../../`)
  - GoogleSignInSwiftSupport/unit (from `../../../`)

[thomasvl]

Re-reading https://blog.cocoapods.org/CocoaPods-1.5.0/#modular-headers, is where I see it talking about pod_target_xcconfig.

[thomasvl]

I guess I'll go ahead and land this and cut a updated release and see if we hear anything else.