fix: address post-landing comments (#251)

Fixes: #76
google · Jan 29, 2019 · 7738ba5 · 7738ba5
1 parent 6576fc6
commit 7738ba5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test/test-kitchen.ts b/test/test-kitchen.ts
@@ -29,7 +29,7 @@ interface ExecError extends Error {
 }
 
 function isExecError(err: Error | ExecError): err is ExecError {
-  return (err as ExecError).code !== undefined;
+  return err && (err as ExecError).code !== undefined;
 }
 
 // cp.exec doesn't fit the (err ^ result) pattern because a process can write
@@ -46,7 +46,7 @@ const execp = (
     cp.exec(
       command,
       execOptions || {},
-      (err: Error | ExecError | null, stdout, stderr) => {
+      (err: cp.ExecException | null, stdout, stderr) => {
         resolve({
           exitCode: err && isExecError(err) ? err.code : 0,
           stdout,