Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tsconfig target setting #147

Closed
ofrobots opened this issue Apr 23, 2018 · 0 comments
Closed

Bump tsconfig target setting #147

ofrobots opened this issue Apr 23, 2018 · 0 comments

Comments

@ofrobots
Copy link
Contributor

@JustinBeckwith asked in #146:

May as well bump target in tsconfig.js to at least es2016. It's even possible es2017 works here 🥁

  • There is only one feature in in ES2016 that is missing from Node 6 – exponentiation operator. There is a slight risk that transpiled code will not work with Node 6 if exponentiation operator is in use, but given that the use is rare, I think it makes sense to use es2016 as the default. Users that run into trouble can always downgrade the target in their tsconfig.json. There is significant benefit to majority of the users from es2016.
  • es2017 has features that are only available in Node 8+ (e.g. async functions). I'm 👎 on switching to it.
@ofrobots ofrobots changed the title Bump Bump tsconfig target setting Apr 23, 2018
ofrobots added a commit to ofrobots/ts-style that referenced this issue Apr 23, 2018
@ofrobots
feat: change default target to es2016
f3ddd0c 
BREAKING CHANGE: since we no longer support Node 4.x, we can default
to the target ES2016.

Fixes: google#147
@ofrobots ofrobots mentioned this issue Apr 23, 2018
Merged
ofrobots added a commit that referenced this issue Apr 23, 2018
@ofrobots
feat: change default target to es2016 (#149)
145ca8b 
BREAKING CHANGE: since we no longer support Node 4.x, we can default
to the target ES2016.

Fixes: #147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ofrobots