feat: ability to use user provided tslint config #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 96.01% 96.75% +0.74%
==========================================
Files 10 10
Lines 326 339 +13
Branches 22 24 +2
==========================================
+ Hits 313 328 +15
+ Misses 13 11 -2
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Jun 1, 2018
This change adds the ability to use tslint.conf provided by the user. If the user doesn't have a config file, we fall back to the default gts config file.
|
@JustinBeckwith added some wording in the README. PTAL. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to use tslint.conf provided by the user.
If the user doesn't have a config file, we fall back to the default
gts config file.
This depends on #158, so ignore that commit when reviewing. That commit will be removed once #158 lands.
We do prefer the user-provided config file over the default now, which is potentially breaking, but I doubt users ever had the reason to have a local
tslint.jsonbefore. I don't think this is semver major, but feel free to push back.