Add more tests #182
Merged
Add more tests #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 99.13% 98.15% -0.98%
==========================================
Files 10 12 +2
Lines 460 652 +192
Branches 31 55 +24
==========================================
+ Hits 456 640 +184
- Misses 4 12 +8
Continue to review full report at Codecov.
|
| files: string[]; | ||
| license: string; | ||
| keywords: string[]; | ||
| name?: string; |
There was a problem hiding this comment.
May be that I'm missing context - why are these all optional now?
There was a problem hiding this comment.
They should always have been optional. The schema for package.json isn't very strong and there is no requirement that all of these keys must be present.
| @@ -37,7 +37,7 @@ const OPTIONS: Options = { | |||
| logger: {log: console.log, error: console.error, dir: nop} | |||
| }; | |||
|
|
|||
| test.serial('format should return false for well-formatted files', t => { | |||
| test.serial('format should return true for well-formatted files', t => { | |||
There was a problem hiding this comment.
Well that's confusing :) Was the title of the test just wrong before?
JustinBeckwith
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to improve coverage, I started working some tests. It turns out that our current coverage numbers are a lie as
init.tswasn't accounted for. It only gets tested viatest-kitchen.tswhich is hard to report for coverage purposes (it uses an tarball-installed version of the package rather than the existing files).Here some more tests. Still more to come, but no reason to sit on these. These can land.