Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos #231

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Fixed typos #231

merged 2 commits into from
Nov 26, 2018

Conversation

Maxim-Mazurok
Copy link
Contributor

In code:

  • Changed "DEFUALT_PACKAGE_JSON" to "DEFAULT_PACKAGE_JSON" (usages also updated)

In comments:

  • Changed "defualt" to "default"
  • Changed "sensistive" to "sensitive"
  • Changed "inlcude" to "include"

@codecov-io
Copy link

codecov-io commented Nov 25, 2018

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          12       12           
  Lines         814      814           
  Branches       65       65           
=======================================
  Hits          802      802           
  Misses         12       12
Impacted Files Coverage Δ
test/test-lint.ts 100% <ø> (ø) ⬆️
test/test-init.ts 100% <ø> (ø) ⬆️
src/init.ts 88.99% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebcad2...688e430. Read the comment docs.

@Maxim-Mazurok
Copy link
Contributor Author

@JustinBeckwith I can see that you've merged my branch, but the pull request is still open.. Is it some kind of GitHub error, or I'm not getting it?...

@ofrobots
Copy link
Contributor

Thanks for the fixes @Maxim-Mazurok ! I will go ahead and land it now.

That status update about 'merge branch' is when someone (@JustinBeckwith in this case) uses the 'Update Branch' button to auto-resolve merge conflicts.

@ofrobots ofrobots merged commit e29fc14 into google:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants