feat!: switch to prettier for formatting #259
Conversation
prettier.config.js
Outdated
| @@ -0,0 +1,9 @@ | |||
| module.exports = { | |||
| bracketSpacing: false, | |||
There was a problem hiding this comment.
I know the point here isn't to paint the bikeshed, but I personally like bracket spacing ducks
There was a problem hiding this comment.
If you look at the delta, this is ported from the .prettierrc that you added.
Is there rationalization for the value you used?
There was a problem hiding this comment.
I had just copied over what's used in all of the other libraries 🤷♂️ I doubt those choices were really scrutinized. I don't have a strong opinion here, just a preference for defaults when nobody otherwise cares. What do you think?
There was a problem hiding this comment.
I've updated the config to a minimal set (IMO). PTAL.
|
Not sure if on purpose or a typo - why the |
|
TIL! That's an awesome idea folks. I have no forking clue which of my commits today are breaking changes. |
BREAKING CHANGE: Switch to prettier as the code formatter. Fixes: google#156
|
@google/google-node-team any opinions on the default prettier config? |
Codecov Report
@@ Coverage Diff @@
## next #259 +/- ##
==========================================
- Coverage 98.29% 98.17% -0.12%
==========================================
Files 12 13 +1
Lines 823 769 -54
Branches 69 61 -8
==========================================
- Hits 809 755 -54
Misses 14 14
Continue to review full report at Codecov.
|
|
NOTE to reviewers: the third commit is a result of reformatting. It would be easier to review just the first two commits independently. |
|
PTAL. |
| test.serial('format should leave the kitty unharmed', t => { | ||
| const KITTY = ` | ||
| /\\**/\\ | ||
| ( o_o )_) |
* feat!: switch to prettier for formatting BREAKING CHANGE: Switch to prettier as the code formatter. Fixes: #156
NOTE: this targets the next branch.
BREAKING CHANGE: Switch to prettier as the code formatter.