-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: conditionally require lint, format #49
Conversation
@JustinBeckwith WDYT? If we are doing this, then we should also add a This would imply that typescript version is determined by Another way to fix this would be to make sure we never have import |
I appreciate what you're trying to do - but I think this introduces more problems than it solves. It's so very important to let the user control the version of Is there a way to have init fail if typescript isn't already installed? Or install typescript as a peer dependency for the user? |
@ofrobots @JustinBeckwith PTAL |
src/cli.ts
Outdated
@@ -74,9 +75,13 @@ async function run(verb: string): Promise<boolean> { | |||
yes: cli.flags.yes || cli.flags.y || false, | |||
logger: logger | |||
}; | |||
// See: https://github.com/google/ts-style/issues/48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it would be better to explain the reason why we are doing this here in a comment. You can additionally link to the issue, but the gist of the intention should be clear here.
For posterity, it is worth documenting why we don't want to directly depend on typescript (i.e. enforce the typescript version for the users of
|
Addresses #48