5151@ GwtCompatible (emulated = true )
5252public class LongsTest extends TestCase {
5353 private static final long [] EMPTY = {};
54- private static final long [] ARRAY1 = {( long ) 1 };
55- private static final long [] ARRAY234 = {( long ) 2 , ( long ) 3 , ( long ) 4 };
54+ private static final long [] ARRAY1 = {1L };
55+ private static final long [] ARRAY234 = {2L , 3L , 4L };
5656
57- private static final long [] VALUES = {MIN_VALUE , ( long ) - 1 , ( long ) 0 , ( long ) 1 , MAX_VALUE };
57+ private static final long [] VALUES = {MIN_VALUE , - 1L , 0L , 1L , MAX_VALUE };
5858
5959 @ GwtIncompatible // Long.hashCode returns different values in GWT.
6060 public void testHashCode () {
@@ -79,25 +79,24 @@ public void testCompare() {
7979 }
8080
8181 public void testContains () {
82- assertThat (Longs .contains (EMPTY , ( long ) 1 )).isFalse ();
83- assertThat (Longs .contains (ARRAY1 , ( long ) 2 )).isFalse ();
84- assertThat (Longs .contains (ARRAY234 , ( long ) 1 )).isFalse ();
85- assertThat (Longs .contains (new long [] {( long ) - 1 }, ( long ) - 1 )).isTrue ();
86- assertThat (Longs .contains (ARRAY234 , ( long ) 2 )).isTrue ();
87- assertThat (Longs .contains (ARRAY234 , ( long ) 3 )).isTrue ();
88- assertThat (Longs .contains (ARRAY234 , ( long ) 4 )).isTrue ();
82+ assertThat (Longs .contains (EMPTY , 1L )).isFalse ();
83+ assertThat (Longs .contains (ARRAY1 , 2L )).isFalse ();
84+ assertThat (Longs .contains (ARRAY234 , 1L )).isFalse ();
85+ assertThat (Longs .contains (new long [] {- 1L }, - 1L )).isTrue ();
86+ assertThat (Longs .contains (ARRAY234 , 2L )).isTrue ();
87+ assertThat (Longs .contains (ARRAY234 , 3L )).isTrue ();
88+ assertThat (Longs .contains (ARRAY234 , 4L )).isTrue ();
8989 }
9090
9191 public void testIndexOf () {
92- assertThat (Longs .indexOf (EMPTY , (long ) 1 )).isEqualTo (-1 );
93- assertThat (Longs .indexOf (ARRAY1 , (long ) 2 )).isEqualTo (-1 );
94- assertThat (Longs .indexOf (ARRAY234 , (long ) 1 )).isEqualTo (-1 );
95- assertThat (Longs .indexOf (new long [] {(long ) -1 }, (long ) -1 )).isEqualTo (0 );
96- assertThat (Longs .indexOf (ARRAY234 , (long ) 2 )).isEqualTo (0 );
97- assertThat (Longs .indexOf (ARRAY234 , (long ) 3 )).isEqualTo (1 );
98- assertThat (Longs .indexOf (ARRAY234 , (long ) 4 )).isEqualTo (2 );
99- assertThat (Longs .indexOf (new long [] {(long ) 2 , (long ) 3 , (long ) 2 , (long ) 3 }, (long ) 3 ))
100- .isEqualTo (1 );
92+ assertThat (Longs .indexOf (EMPTY , 1L )).isEqualTo (-1 );
93+ assertThat (Longs .indexOf (ARRAY1 , 2L )).isEqualTo (-1 );
94+ assertThat (Longs .indexOf (ARRAY234 , 1L )).isEqualTo (-1 );
95+ assertThat (Longs .indexOf (new long [] {-1L }, -1L )).isEqualTo (0 );
96+ assertThat (Longs .indexOf (ARRAY234 , 2L )).isEqualTo (0 );
97+ assertThat (Longs .indexOf (ARRAY234 , 3L )).isEqualTo (1 );
98+ assertThat (Longs .indexOf (ARRAY234 , 4L )).isEqualTo (2 );
99+ assertThat (Longs .indexOf (new long [] {2L , 3L , 2L , 3L }, 3L )).isEqualTo (1 );
101100 }
102101
103102 public void testIndexOf_arrayTarget () {
@@ -108,42 +107,27 @@ public void testIndexOf_arrayTarget() {
108107 assertThat (Longs .indexOf (ARRAY1 , ARRAY234 )).isEqualTo (-1 );
109108 assertThat (Longs .indexOf (ARRAY1 , ARRAY1 )).isEqualTo (0 );
110109 assertThat (Longs .indexOf (ARRAY234 , ARRAY234 )).isEqualTo (0 );
111- assertThat (Longs .indexOf (ARRAY234 , new long [] {(long ) 2 , (long ) 3 })).isEqualTo (0 );
112- assertThat (Longs .indexOf (ARRAY234 , new long [] {(long ) 3 , (long ) 4 })).isEqualTo (1 );
113- assertThat (Longs .indexOf (ARRAY234 , new long [] {(long ) 3 })).isEqualTo (1 );
114- assertThat (Longs .indexOf (ARRAY234 , new long [] {(long ) 4 })).isEqualTo (2 );
115- assertThat (
116- Longs .indexOf (
117- new long [] {(long ) 2 , (long ) 3 , (long ) 3 , (long ) 3 , (long ) 3 },
118- new long [] {(long ) 3 }))
119- .isEqualTo (1 );
120- assertThat (
121- Longs .indexOf (
122- new long [] {(long ) 2 , (long ) 3 , (long ) 2 , (long ) 3 , (long ) 4 , (long ) 2 , (long ) 3 },
123- new long [] {(long ) 2 , (long ) 3 , (long ) 4 }))
110+ assertThat (Longs .indexOf (ARRAY234 , new long [] {2L , 3L })).isEqualTo (0 );
111+ assertThat (Longs .indexOf (ARRAY234 , new long [] {3L , 4L })).isEqualTo (1 );
112+ assertThat (Longs .indexOf (ARRAY234 , new long [] {3L })).isEqualTo (1 );
113+ assertThat (Longs .indexOf (ARRAY234 , new long [] {4L })).isEqualTo (2 );
114+ assertThat (Longs .indexOf (new long [] {2L , 3L , 3L , 3L , 3L }, new long [] {3L })).isEqualTo (1 );
115+ assertThat (Longs .indexOf (new long [] {2L , 3L , 2L , 3L , 4L , 2L , 3L }, new long [] {2L , 3L , 4L }))
124116 .isEqualTo (2 );
125- assertThat (
126- Longs .indexOf (
127- new long [] {(long ) 2 , (long ) 2 , (long ) 3 , (long ) 4 , (long ) 2 , (long ) 3 , (long ) 4 },
128- new long [] {(long ) 2 , (long ) 3 , (long ) 4 }))
117+ assertThat (Longs .indexOf (new long [] {2L , 2L , 3L , 4L , 2L , 3L , 4L }, new long [] {2L , 3L , 4L }))
129118 .isEqualTo (1 );
130- assertThat (
131- Longs .indexOf (
132- new long [] {(long ) 4 , (long ) 3 , (long ) 2 },
133- new long [] {(long ) 2 , (long ) 3 , (long ) 4 }))
134- .isEqualTo (-1 );
119+ assertThat (Longs .indexOf (new long [] {4L , 3L , 2L }, new long [] {2L , 3L , 4L })).isEqualTo (-1 );
135120 }
136121
137122 public void testLastIndexOf () {
138- assertThat (Longs .lastIndexOf (EMPTY , (long ) 1 )).isEqualTo (-1 );
139- assertThat (Longs .lastIndexOf (ARRAY1 , (long ) 2 )).isEqualTo (-1 );
140- assertThat (Longs .lastIndexOf (ARRAY234 , (long ) 1 )).isEqualTo (-1 );
141- assertThat (Longs .lastIndexOf (new long [] {(long ) -1 }, (long ) -1 )).isEqualTo (0 );
142- assertThat (Longs .lastIndexOf (ARRAY234 , (long ) 2 )).isEqualTo (0 );
143- assertThat (Longs .lastIndexOf (ARRAY234 , (long ) 3 )).isEqualTo (1 );
144- assertThat (Longs .lastIndexOf (ARRAY234 , (long ) 4 )).isEqualTo (2 );
145- assertThat (Longs .lastIndexOf (new long [] {(long ) 2 , (long ) 3 , (long ) 2 , (long ) 3 }, (long ) 3 ))
146- .isEqualTo (3 );
123+ assertThat (Longs .lastIndexOf (EMPTY , 1L )).isEqualTo (-1 );
124+ assertThat (Longs .lastIndexOf (ARRAY1 , 2L )).isEqualTo (-1 );
125+ assertThat (Longs .lastIndexOf (ARRAY234 , 1L )).isEqualTo (-1 );
126+ assertThat (Longs .lastIndexOf (new long [] {-1L }, -1L )).isEqualTo (0 );
127+ assertThat (Longs .lastIndexOf (ARRAY234 , 2L )).isEqualTo (0 );
128+ assertThat (Longs .lastIndexOf (ARRAY234 , 3L )).isEqualTo (1 );
129+ assertThat (Longs .lastIndexOf (ARRAY234 , 4L )).isEqualTo (2 );
130+ assertThat (Longs .lastIndexOf (new long [] {2L , 3L , 2L , 3L }, 3L )).isEqualTo (3 );
147131 }
148132
149133 public void testMax_noArgs () {
@@ -153,8 +137,7 @@ public void testMax_noArgs() {
153137 public void testMax () {
154138 assertThat (max (MIN_VALUE )).isEqualTo (MIN_VALUE );
155139 assertThat (max (MAX_VALUE )).isEqualTo (MAX_VALUE );
156- assertThat (max ((long ) 8 , (long ) 6 , (long ) 7 , (long ) 5 , (long ) 3 , (long ) 0 , (long ) 9 ))
157- .isEqualTo ((long ) 9 );
140+ assertThat (max (8L , 6L , 7L , 5L , 3L , 0L , 9L )).isEqualTo (9L );
158141 }
159142
160143 public void testMin_noArgs () {
@@ -164,18 +147,16 @@ public void testMin_noArgs() {
164147 public void testMin () {
165148 assertThat (min (MIN_VALUE )).isEqualTo (MIN_VALUE );
166149 assertThat (min (MAX_VALUE )).isEqualTo (MAX_VALUE );
167- assertThat (min ((long ) 8 , (long ) 6 , (long ) 7 , (long ) 5 , (long ) 3 , (long ) 0 , (long ) 9 ))
168- .isEqualTo ((long ) 0 );
150+ assertThat (min (8L , 6L , 7L , 5L , 3L , 0L , 9L )).isEqualTo (0L );
169151 }
170152
171153 public void testConstrainToRange () {
172- assertThat (Longs .constrainToRange ((long ) 1 , (long ) 0 , (long ) 5 )).isEqualTo ((long ) 1 );
173- assertThat (Longs .constrainToRange ((long ) 1 , (long ) 1 , (long ) 5 )).isEqualTo ((long ) 1 );
174- assertThat (Longs .constrainToRange ((long ) 1 , (long ) 3 , (long ) 5 )).isEqualTo ((long ) 3 );
175- assertThat (Longs .constrainToRange ((long ) 0 , (long ) -5 , (long ) -1 )).isEqualTo ((long ) -1 );
176- assertThat (Longs .constrainToRange ((long ) 5 , (long ) 2 , (long ) 2 )).isEqualTo ((long ) 2 );
177- assertThrows (
178- IllegalArgumentException .class , () -> Longs .constrainToRange ((long ) 1 , (long ) 3 , (long ) 2 ));
154+ assertThat (Longs .constrainToRange (1L , 0L , 5L )).isEqualTo (1L );
155+ assertThat (Longs .constrainToRange (1L , 1L , 5L )).isEqualTo (1L );
156+ assertThat (Longs .constrainToRange (1L , 3L , 5L )).isEqualTo (3L );
157+ assertThat (Longs .constrainToRange (0L , -5L , -1L )).isEqualTo (-1L );
158+ assertThat (Longs .constrainToRange (5L , 2L , 2L )).isEqualTo (2L );
159+ assertThrows (IllegalArgumentException .class , () -> Longs .constrainToRange (1L , 3L , 2L ));
179160 }
180161
181162 public void testConcat () {
@@ -185,10 +166,8 @@ public void testConcat() {
185166 assertThat (Longs .concat (ARRAY1 )).isEqualTo (ARRAY1 );
186167 assertThat (Longs .concat (ARRAY1 )).isNotSameInstanceAs (ARRAY1 );
187168 assertThat (Longs .concat (EMPTY , ARRAY1 , EMPTY )).isEqualTo (ARRAY1 );
188- assertThat (Longs .concat (ARRAY1 , ARRAY1 , ARRAY1 ))
189- .isEqualTo (new long [] {(long ) 1 , (long ) 1 , (long ) 1 });
190- assertThat (Longs .concat (ARRAY1 , ARRAY234 ))
191- .isEqualTo (new long [] {(long ) 1 , (long ) 2 , (long ) 3 , (long ) 4 });
169+ assertThat (Longs .concat (ARRAY1 , ARRAY1 , ARRAY1 )).isEqualTo (new long [] {1L , 1L , 1L });
170+ assertThat (Longs .concat (ARRAY1 , ARRAY234 )).isEqualTo (new long [] {1L , 2L , 3L , 4L });
192171 }
193172
194173 @ GwtIncompatible // different overflow behavior; could probably be made to work by using ~~
@@ -302,8 +281,7 @@ public void testEnsureCapacity() {
302281 assertThat (Longs .ensureCapacity (EMPTY , 0 , 1 )).isSameInstanceAs (EMPTY );
303282 assertThat (Longs .ensureCapacity (ARRAY1 , 0 , 1 )).isSameInstanceAs (ARRAY1 );
304283 assertThat (Longs .ensureCapacity (ARRAY1 , 1 , 1 )).isSameInstanceAs (ARRAY1 );
305- assertThat (Longs .ensureCapacity (ARRAY1 , 2 , 1 ))
306- .isEqualTo (new long [] {(long ) 1 , (long ) 0 , (long ) 0 });
284+ assertThat (Longs .ensureCapacity (ARRAY1 , 2 , 1 )).isEqualTo (new long [] {1L , 0L , 0L });
307285 }
308286
309287 public void testEnsureCapacity_fail () {
@@ -314,8 +292,8 @@ public void testEnsureCapacity_fail() {
314292 public void testJoin () {
315293 assertThat (Longs .join ("," , EMPTY )).isEmpty ();
316294 assertThat (Longs .join ("," , ARRAY1 )).isEqualTo ("1" );
317- assertThat (Longs .join ("," , ( long ) 1 , ( long ) 2 )).isEqualTo ("1,2" );
318- assertThat (Longs .join ("" , ( long ) 1 , ( long ) 2 , ( long ) 3 )).isEqualTo ("123" );
295+ assertThat (Longs .join ("," , 1L , 2L )).isEqualTo ("1,2" );
296+ assertThat (Longs .join ("" , 1L , 2L , 3L )).isEqualTo ("123" );
319297 }
320298
321299 public void testLexicographicalComparator () {
@@ -324,10 +302,10 @@ public void testLexicographicalComparator() {
324302 new long [] {},
325303 new long [] {MIN_VALUE },
326304 new long [] {MIN_VALUE , MIN_VALUE },
327- new long [] {MIN_VALUE , ( long ) 1 },
328- new long [] {( long ) 1 },
329- new long [] {( long ) 1 , MIN_VALUE },
330- new long [] {MAX_VALUE , MAX_VALUE - ( long ) 1 },
305+ new long [] {MIN_VALUE , 1L },
306+ new long [] {1L },
307+ new long [] {1L , MIN_VALUE },
308+ new long [] {MAX_VALUE , MAX_VALUE - 1L },
331309 new long [] {MAX_VALUE , MAX_VALUE },
332310 new long [] {MAX_VALUE , MAX_VALUE , MAX_VALUE });
333311
@@ -509,12 +487,12 @@ public void testToArray() {
509487 List <Long > none = Arrays .<Long >asList ();
510488 assertThat (Longs .toArray (none )).isEqualTo (EMPTY );
511489
512- List <Long > one = Arrays .asList (( long ) 1 );
490+ List <Long > one = Arrays .asList (1L );
513491 assertThat (Longs .toArray (one )).isEqualTo (ARRAY1 );
514492
515- long [] array = {( long ) 0 , ( long ) 1 , 0x0FF1C1AL };
493+ long [] array = {0L , 1L , 0x0FF1C1AL };
516494
517- List <Long > three = Arrays .asList (( long ) 0 , ( long ) 1 , 0x0FF1C1AL );
495+ List <Long > three = Arrays .asList (0L , 1L , 0x0FF1C1AL );
518496 assertThat (Longs .toArray (three )).isEqualTo (array );
519497
520498 assertThat (Longs .toArray (Longs .asList (array ))).isEqualTo (array );
@@ -536,18 +514,18 @@ public void testToArray_threadSafe() {
536514 }
537515
538516 public void testToArray_withNull () {
539- List <@ Nullable Long > list = Arrays .asList (( long ) 0 , ( long ) 1 , null );
517+ List <@ Nullable Long > list = Arrays .asList (0L , 1L , null );
540518 assertThrows (NullPointerException .class , () -> Longs .toArray (list ));
541519 }
542520
543521 public void testToArray_withConversion () {
544- long [] array = {( long ) 0 , ( long ) 1 , ( long ) 2 };
522+ long [] array = {0L , 1L , 2L };
545523
546524 List <Byte > bytes = Arrays .asList ((byte ) 0 , (byte ) 1 , (byte ) 2 );
547525 List <Short > shorts = Arrays .asList ((short ) 0 , (short ) 1 , (short ) 2 );
548526 List <Integer > ints = Arrays .asList (0 , 1 , 2 );
549527 List <Float > floats = Arrays .asList ((float ) 0 , (float ) 1 , (float ) 2 );
550- List <Long > longs = Arrays .asList (( long ) 0 , ( long ) 1 , ( long ) 2 );
528+ List <Long > longs = Arrays .asList (0L , 1L , 2L );
551529 List <Double > doubles = Arrays .asList ((double ) 0 , (double ) 1 , (double ) 2 );
552530
553531 assertThat (Longs .toArray (bytes )).isEqualTo (array );
@@ -560,31 +538,31 @@ public void testToArray_withConversion() {
560538
561539 @ J2ktIncompatible // b/239034072: Kotlin varargs copy parameter arrays.
562540 public void testAsList_isAView () {
563- long [] array = {( long ) 0 , ( long ) 1 };
541+ long [] array = {0L , 1L };
564542 List <Long > list = Longs .asList (array );
565- list .set (0 , ( long ) 2 );
566- assertThat (array ).isEqualTo (new long [] {( long ) 2 , ( long ) 1 });
567- array [1 ] = ( long ) 3 ;
568- assertThat (list ).containsExactly (( long ) 2 , ( long ) 3 ).inOrder ();
543+ list .set (0 , 2L );
544+ assertThat (array ).isEqualTo (new long [] {2L , 1L });
545+ array [1 ] = 3L ;
546+ assertThat (list ).containsExactly (2L , 3L ).inOrder ();
569547 }
570548
571549 public void testAsList_toArray_roundTrip () {
572- long [] array = {( long ) 0 , ( long ) 1 , ( long ) 2 };
550+ long [] array = {0L , 1L , 2L };
573551 List <Long > list = Longs .asList (array );
574552 long [] newArray = Longs .toArray (list );
575553
576554 // Make sure it returned a copy
577- list .set (0 , ( long ) 4 );
578- assertThat (newArray ).isEqualTo (new long [] {( long ) 0 , ( long ) 1 , ( long ) 2 });
579- newArray [1 ] = ( long ) 5 ;
580- assertThat ((long ) list .get (1 )).isEqualTo (( long ) 1 );
555+ list .set (0 , 4L );
556+ assertThat (newArray ).isEqualTo (new long [] {0L , 1L , 2L });
557+ newArray [1 ] = 5L ;
558+ assertThat ((long ) list .get (1 )).isEqualTo (1L );
581559 }
582560
583561 // This test stems from a real bug found by andrewk
584562 public void testAsList_subList_toArray_roundTrip () {
585- long [] array = {( long ) 0 , ( long ) 1 , ( long ) 2 , ( long ) 3 };
563+ long [] array = {0L , 1L , 2L , 3L };
586564 List <Long > list = Longs .asList (array );
587- assertThat (Longs .toArray (list .subList (1 , 3 ))).isEqualTo (new long [] {( long ) 1 , ( long ) 2 });
565+ assertThat (Longs .toArray (list .subList (1 , 3 ))).isEqualTo (new long [] {1L , 2L });
588566 assertThat (Longs .toArray (list .subList (2 , 2 ))).isEqualTo (new long [] {});
589567 }
590568
@@ -678,9 +656,9 @@ private static void tryParseAndAssertEquals(Long expected, String value) {
678656
679657 public void testTryParse_radix () {
680658 for (int radix = Character .MIN_RADIX ; radix <= Character .MAX_RADIX ; radix ++) {
681- radixEncodeParseAndAssertEquals (( long ) 0 , radix );
682- radixEncodeParseAndAssertEquals (( long ) 8000 , radix );
683- radixEncodeParseAndAssertEquals (( long ) - 8000 , radix );
659+ radixEncodeParseAndAssertEquals (0L , radix );
660+ radixEncodeParseAndAssertEquals (8000L , radix );
661+ radixEncodeParseAndAssertEquals (- 8000L , radix );
684662 radixEncodeParseAndAssertEquals (MAX_VALUE , radix );
685663 radixEncodeParseAndAssertEquals (MIN_VALUE , radix );
686664 assertWithMessage ("Radix: " + radix )
0 commit comments