Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOE Sync 2020-09-29 #5252

Merged
merged 5 commits into from
Sep 29, 2020
Merged

MOE Sync 2020-09-29 #5252

merged 5 commits into from
Sep 29, 2020

Conversation

cgdecker
Copy link
Member

This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.

Commits:

Internal changes to ClassPath.

643423a


Internal changes to ClassPath.

b7e83b1


Remove unnecessary parens

Fixes #4036

30c69a1


Also print Android test failures.

0644480


Fix ClassPathTest on Android JDK 11.

037e10c

fluentfuture and others added 5 commits September 29, 2020 00:48
RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=333547909
RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=333752825
Fixes #4036

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=334163542
RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=334196405
RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=334217434
@cgdecker cgdecker added the internal-sync A PR that represents a push from Google's internal repo label Sep 29, 2020
@google-cla
Copy link

google-cla bot commented Sep 29, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 29, 2020
@cgdecker cgdecker added cla: yes and removed cla: no labels Sep 29, 2020
@cgdecker
Copy link
Member Author

Setting cla: yes because the commit by another author is derived directly from PR #4036 from that author.

@cgdecker cgdecker merged commit 7f164ef into master Sep 29, 2020
@cgdecker cgdecker deleted the sync-master-2020/09/28 branch September 29, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes internal-sync A PR that represents a push from Google's internal repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants