Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RateLimiter.java #5614

Closed
wants to merge 1 commit into from
Closed

Conversation

ahmedElatrouz
Copy link

Removing the @beta from the RateLimiter

Removing the @beta from the RateLimiter
@google-cla
Copy link

google-cla bot commented Jun 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 18, 2021
@ahmedElatrouz
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 18, 2021
@cgdecker
Copy link
Member

Thanks for the PR, but removing @Beta is more of an issue of deciding that we're ok with locking down the API as it is and committing to not making breaking changes. In general we're trying to be more open to that, but I'm not sure about RateLimiter because I believe the person on our team who's worked with it the most feels there are some shortcomings to the design. I'm going to close this PR (we can pretty easily remove the annotation when we decide it should happen) but I'll see if I can get a more informed opinion on #5612.

@cgdecker cgdecker closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants