ci: add GitHub token permissions for workflow #6106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Sharma <varunsh@stepsecurity.io>
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Varun Sharma <varunsh@stepsecurity.io> Closes #6106 RELNOTES=n/a PiperOrigin-RevId: 460729188
32 tasks
87 tasks
copybara-service bot
pushed a commit
to google/jimfs
that referenced
this pull request
Sep 3, 2025
- google/truth#1413 - google/auto#1900 - #401 Compare cl/460733976 from google/guava#6106. I notice that that earlier CL also added a `permissions` section for the `test` job, both for reading (for `actions/checkout`) and for writing (for `styfle/cancel-workflow-action`, which apparently [we probably shouldn't be using nowadays](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#:~:text=You%20probably%20don%27t%20need%20to%20install%20this%20custom%20action) and which [might not even need the explicit permissions](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#advanced-token-permissions)?). I'm not worrying about that for now, but that offers further evidence that I have no idea what I'm doing here. RELNOTES=n/a PiperOrigin-RevId: 802304800
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Sep 3, 2025
- #1413 - google/auto#1900 - google/jimfs#401 Compare cl/460733976 from google/guava#6106. I notice that that earlier CL also added a `permissions` section for the `test` job, both for reading (for `actions/checkout`) and for writing (for `styfle/cancel-workflow-action`, which apparently [we probably shouldn't be using nowadays](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#:~:text=You%20probably%20don%27t%20need%20to%20install%20this%20custom%20action) and which [might not even need the explicit permissions](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#advanced-token-permissions)?). I'm not worrying about that for now, but that offers further evidence that I have no idea what I'm doing here. RELNOTES=n/a PiperOrigin-RevId: 802304800
This was referenced Sep 3, 2025
copybara-service bot
pushed a commit
to google/auto
that referenced
this pull request
Sep 3, 2025
- google/truth#1413 - #1900 - google/jimfs#401 Compare cl/460733976 from google/guava#6106. I notice that that earlier CL also added a `permissions` section for the `test` job, both for reading (for `actions/checkout`) and for writing (for `styfle/cancel-workflow-action`, which apparently [we probably shouldn't be using nowadays](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#:~:text=You%20probably%20don%27t%20need%20to%20install%20this%20custom%20action) and which [might not even need the explicit permissions](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#advanced-token-permissions)?). I'm not worrying about that for now, but that offers further evidence that I have no idea what I'm doing here. RELNOTES=n/a PiperOrigin-RevId: 802304800
copybara-service bot
pushed a commit
to google/jimfs
that referenced
this pull request
Sep 3, 2025
- google/truth#1413 - google/auto#1900 - #401 Compare cl/460733976 from google/guava#6106. I notice that that earlier CL also added a `permissions` section for the `test` job, both for reading (for `actions/checkout`) and for writing (for `styfle/cancel-workflow-action`, which apparently [we probably shouldn't be using nowadays](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#:~:text=You%20probably%20don%27t%20need%20to%20install%20this%20custom%20action) and which [might not even need the explicit permissions](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#advanced-token-permissions)?). I'm not worrying about that for now, but that offers further evidence that I have no idea what I'm doing here. RELNOTES=n/a PiperOrigin-RevId: 802346694
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Sep 3, 2025
- #1413 - google/auto#1900 - google/jimfs#401 Compare cl/460733976 from google/guava#6106. I notice that that earlier CL also added a `permissions` section for the `test` job, both for reading (for `actions/checkout`) and for writing (for `styfle/cancel-workflow-action`, which apparently [we probably shouldn't be using nowadays](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#:~:text=You%20probably%20don%27t%20need%20to%20install%20this%20custom%20action) and which [might not even need the explicit permissions](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#advanced-token-permissions)?). I'm not worrying about that for now, but that offers further evidence that I have no idea what I'm doing here. RELNOTES=n/a PiperOrigin-RevId: 802346694
copybara-service bot
pushed a commit
to google/auto
that referenced
this pull request
Sep 3, 2025
- google/truth#1413 - #1900 - google/jimfs#401 Compare cl/460733976 from google/guava#6106. I notice that that earlier CL also added a `permissions` section for the `test` job, both for reading (for `actions/checkout`) and for writing (for `styfle/cancel-workflow-action`, which apparently [we probably shouldn't be using nowadays](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#:~:text=You%20probably%20don%27t%20need%20to%20install%20this%20custom%20action) and which [might not even need the explicit permissions](https://github.com/styfle/cancel-workflow-action/blob/main/README.md#advanced-token-permissions)?). I'm not worrying about that for now, but that offers further evidence that I have no idea what I'm doing here. RELNOTES=n/a PiperOrigin-RevId: 802346694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minimum token permissions for the GITHUB_TOKEN using https://github.com/step-security/secure-workflows.
GitHub recommends defining minimum GITHUB_TOKEN permissions for securing GitHub Actions workflows
This project is part of the top 100 critical projects as per OpenSSF (https://github.com/ossf/wg-securing-critical-projects), so fixing the token permissions to improve security.
Signed-off-by: Varun Sharma varunsh@stepsecurity.io