Add a missing @Nullable annotation identified by [RedundantNullCheck](https://github.com/google/error-prone/pull/5121).
#8010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_809750887
branch
from
28f78d8 to
9d2c438
Compare
copybara-service
bot
changed the title
@Nullable annotation identified by [RedundantNullCheck](https://github.com/google/error-prone/issues/5107).@Nullable annotation identified by [RedundantNullCheck](https://github.com/google/error-prone/pull/5121).
…ck`](google/error-prone#5121). Also, use that check as motivation to finally make `AbstractBiMap` more understandable to nullness checkers. While in the area, I also made `inverse` be `private`. That required changing a reference in a subclass in the file to use `super.inverse`. As I understand it from my experience in 856123e, a `private` field like `inverse` is [accessible](https://docs.oracle.com/javase/specs/jls/se24/html/jls-6.html#jls-6.6.1) but not inherited ([1](https://docs.oracle.com/javase/specs/jls/se24/html/jls-8.html#d5e13771), [2](https://docs.oracle.com/javase/specs/jls/se24/html/jls-8.html#jls-8.2)). (And marginally simplify a couple `AbstractBiMap` subclasses by removing unnecessary type arguments.) RELNOTES=n/a PiperOrigin-RevId: 810029934
copybara-service
bot
force-pushed
the
test_809750887
branch
from
9d2c438 to
125fd02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing
@Nullableannotation identified byRedundantNullCheck.Also, use that check as motivation to finally make
AbstractBiMapmore understandable to nullness checkers. While in the area, I also madeinversebeprivate. That required changing a reference in a subclass in the file to usesuper.inverse. As I understand it from my experience in 856123e, aprivatefield likeinverseis accessible but not inherited (1, 2).(And marginally simplify a couple
AbstractBiMapsubclasses by removing unnecessary type arguments.)RELNOTES=n/a