Skip to content

Fix correctly report COLLECTED removal cause in compute() #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix correctly report COLLECTED removal cause in compute() #8070

wants to merge 1 commit into from
+11 −1

Conversation

@bandalgomsu
Copy link

@bandalgomsu bandalgomsu commented Nov 1, 2025

fix #7985

Thanks 🙂

eamonnmcmanus
eamonnmcmanus requested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you add a test that fails without the fix and passes with it?

@chaoren
Copy link
Member

chaoren commented Nov 3, 2025

  1. This fix doesn't seem sufficient to fix the issue.
  2. Please don't add yourself as @author with the fix.
  3. Cache's compute misreports the removal cause of a collected entry #7985 (comment) told you to go ahead and send the PR, but that person is unrelated to the guava team

@chaoren chaoren closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cache's compute misreports the removal cause of a collected entry

3 participants

@bandalgomsu @chaoren @eamonnmcmanus