openfhe: support cyclic repetition for MakePackedPlaintext #1129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #645.
This PR adds cyclic repetition code in openfhe emitter to address the client-interface issue and add_plain/mul_plain issue.
All existing
tests/Example
passes with this change.Problems
In the generated client-interface, should we add assertions that input vector length equals what has been specified (
ciphertext-degree
), and slot num divides input vector length, so that user wont provide malformed input.I added a dot_product example for CKKS,
which turned out to be not workingworks now.The error part comes from the following code. Apprently the onehot selection is not working. Is that the way I treat MakeCKKSPackedPlaintext wrongly?