Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arith-to-cggi-quart pass lowering to TFHE-rs HL emitter #1267

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Arith-to-cggi-quart pass lowering to TFHE-rs HL emitter #1267

merged 1 commit into from
Jan 23, 2025

Conversation

WoutLegiest
Copy link
Collaborator

Follow up of #1265

  • Change the Scalar Right Shift ops definition of CGGI and TFHE-rs to use an index attr to define the shift amount
  • Extended some TFHE-rs ops to allow vectors as operands
  • Further integration of the arith-to-cggi-quart pass lowering to TFHE-rs HL emitter

@WoutLegiest WoutLegiest force-pushed the arith-to-cggi-quart2 branch 3 times, most recently from cb2d168 to ce95967 Compare January 16, 2025 22:06
@WoutLegiest WoutLegiest mentioned this pull request Jan 16, 2025
Merged
@WoutLegiest WoutLegiest force-pushed the arith-to-cggi-quart2 branch 2 times, most recently from 6efec0f to d83d267 Compare January 21, 2025 17:51
@WoutLegiest WoutLegiest mentioned this pull request Jan 22, 2025
Merged
asraa
asraa reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/Dialect/CGGI/Conversions/CGGIToTfheRust/CGGIToTfheRust.cpp Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGIQuart/ArithToCGGIQuart.cpp Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGIQuart/ArithToCGGIQuart.cpp Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGIQuart/ArithToCGGIQuart.cpp Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGIQuart/ArithToCGGIQuart.cpp Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGIQuart/ArithToCGGIQuart.cpp Outdated Show resolved Hide resolved
@WoutLegiest WoutLegiest force-pushed the arith-to-cggi-quart2 branch 2 times, most recently from fd86279 to f42317c Compare January 22, 2025 22:09
@WoutLegiest WoutLegiest requested a review from asraa January 22, 2025 22:11
@WoutLegiest
Working Quart to Tfhe rs + Change tfhe-rs and cggi shift ops
225eb6c 
Co-authored-by: asraa <asraa@google.com>
asraa
asraa approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jan 23, 2025
@copybara-service copybara-service bot merged commit 3f984f7 into google:main Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoutLegiest @asraa