Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Squat Packing's rotate and sum operation and resolved type mismatch issues. #1269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

copybara-service[bot]
Copy link
Contributor

Added Squat Packing's rotate and sum operation and resolved type mismatch issues.

@asraa
Copy link
Collaborator

asraa commented Jan 15, 2025

Hey, this is a rebase of #970 with a major modification that changes how this pass will be applied later:
I modified the pattern converter to only apply the function signature type conversion / func::ReturnOp type conversion when there was a linalg matmul operation in the body that needed to be squat packed.

  • This prevents failure for tests that apply the linalg-to-tensor-ext pass without any matmul operations since the pass promotes the arg shapes
  • In the future, I expect @j2kun 's work on layout inference to actually insert operations that change the function args tiling/packing instead of what this pass does - which is just promote the types to "work" (which is OK for the simple examples).

cc @AlexanderViand-Intel

@AlexanderViand-Intel
Copy link
Collaborator

Thanks @asraa for rebasing and updating this! I agree that the current solution is more than good enough until #1264 is ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants