Add polynomial.eval op for evaluation of a static polynomial #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2kun
requested changes
Jan 16, 2025
There was a problem hiding this comment.
So the tablegen looks mostly good to me! A few small nits, and then I'd suggest adding a test using this new syntax in tests/Dialect/Polynomial/IR/ (could be in, say, int_coefficients.mlir or a new file if you prefer). This will ensure that heir-opt can run, parse+print the syntax you've chosen, as well as run any IR verifiers.
| let description = [{ | ||
| Evaluates the result of a polynomial specified as a static attribute at a given SSA value. | ||
| The result represents the evaluation of the polynomial at the input value and produces | ||
| a corresponding constant value. |
There was a problem hiding this comment.
Suggested change
| a corresponding constant value. | |
| a corresponding scalar value. |
"constant" would imply statically known, and if the input is an SSA value then it's not in general.
| ); | ||
|
|
||
| let results = (outs AnyType:$result); | ||
| let assemblyFormat = "$polynomial attr-dict `polynomial` $value type($value) `->` type($result)"; |
There was a problem hiding this comment.
Suggested change
| let assemblyFormat = "$polynomial attr-dict `polynomial` $value type($value) `->` type($result)"; | |
| let assemblyFormat = "operands attr-dict `:` type($value)"; |
| ```mlir | ||
| #poly = #polynomial.int_polynomial<x**2 + 2*x + 1> | ||
| %x = arith.constant 5 : i32 | ||
| %result = polynomial.eval #poly, %x : !arith.constant |
There was a problem hiding this comment.
Suggested change
| %result = polynomial.eval #poly, %x : !arith.constant | |
| %result = polynomial.eval #poly, %x : i32 |
j2kun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the definition for polynomial.eval op. This operation builds without error but I am not sure if it is the final version. Insights and recommendations are appreciated. #1217