Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade roberts cross and gx_kernel to 64x64 #604

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Upgrade roberts cross and gx_kernel to 64x64 #604

merged 1 commit into from
Apr 18, 2024

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Apr 8, 2024 •
edited
Loading

Rebased over #601 for performance reasons
Part of #571

@j2kun j2kun mentioned this pull request Apr 8, 2024
Closed
@j2kun
Copy link
Collaborator Author

j2kun commented Apr 8, 2024

The failing test gx_kernel_64x64 runs in ~10m on my machine, but apparently times out in CI.

@j2kun j2kun requested a review from asraa April 9, 2024 19:07
@j2kun
Copy link
Collaborator Author

j2kun commented Apr 18, 2024

@asraa ping on this

asraa
asraa approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay!

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Apr 18, 2024
@copybara-service copybara-service bot merged commit 4fabc51 into google:main Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j2kun @asraa