Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a FirebaseUrlFactory #1825

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Add a FirebaseUrlFactory #1825

merged 9 commits into from
Nov 22, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Nov 21, 2023 •
edited
Loading

WHAT

Add a FirebaseUrlFactory. This supports URL.setURLStreamHandlerFactory(FirebaseUrlFactory(client)) to bridge
to OkHttp Call.Factory.

WHY

Firebase uses HttpURLConnection, which provides no visibility or control over requests.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from garanj November 21, 2023 06:45
@yschimke yschimke marked this pull request as ready for review November 21, 2023 07:49
@yschimke yschimke merged commit dad25be into google:main Nov 22, 2023
4 checks passed
@yschimke yschimke deleted the networks_again branch December 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanj garanj garanj approved these changes

@enkhjargal enkhjargal enkhjargal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yschimke @enkhjargal @garanj