Fix bottom padding for responsive() SLC #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Kpeved
reviewed
Nov 21, 2023
| @@ -198,11 +203,12 @@ public object ScalingLazyColumnDefaults { | |||
| index = 0, | |||
| offsetPx = topScreenOffsetPx, | |||
| ), | |||
| autoCentering = null, | |||
There was a problem hiding this comment.
Is that fix replaces some issue with AutoCentering behavior?
There was a problem hiding this comment.
AutoCentering API is this
public class AutoCenteringParams(
// @IntRange(from = 0)
internal val itemIndex: Int = 1,
internal val itemOffset: Int = 0,
)
You can ensure that the top is correctly working. However it doesn't ensure that the bottom can be completely scrolled into view.
So better to disable it, and do it manually with enough content padding at the bottom to allow the last item to be unobscured.
yschimke
commented
Nov 22, 2023
There was a problem hiding this comment.
@Kpeved without this change, the responsive screens hit this issue.
With the change, they can scroll so the last item is mostly not cutoff.
yschimke
commented
Nov 22, 2023
...rologist.screensizes_ScalingLazyColumnDefaultsTest_responsive_end[6]_smalldevicebigfonts.png
Outdated
Show resolved
Hide resolved
yschimke
changed the title
yschimke
commented
Nov 22, 2023
...oid.horologist.screensizes_MediaPlayerLibraryTest_screenshot[2]_samsunggalaxywatch6large.png
Outdated
Show resolved
Hide resolved
# Conflicts: # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_MediaPlayerLibraryTest_screenshot[2]_samsunggalaxywatch6large.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_ScalingLazyColumnDefaultsTest_responsive[2]_samsunggalaxywatch6large.png
|
cc @garanj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fix bottom padding for SLC.
WHY
Bottom item if larger than a Chip, such as a Card will be obscured.
AutoCenteringParams doesn't allow adjusting the bottom item, and with Anchor = Start will only ensure the start of the final item can get to the center, which is not enough.
HOW
Checklist 📋