Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing and deps #2342

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Fix publishing and deps #2342

merged 7 commits into from
Aug 14, 2024

Conversation

yschimke
Copy link
Collaborator

WHAT

Fix publishing and deps

WHY

JDK 17 fails in AGP javadoc generation, bump to recent AGP but still need to disable dokka from AGP.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from luizgrp August 13, 2024 15:24
@yschimke
Copy link
Collaborator Author

@luizgrp heads up

       1.  Dependency 'androidx.navigation:navigation-compose:2.8.0-beta07' requires libraries and applications that
           depend on it to compile against version 35 or later of the
           Android APIs.   

and https://androiddev.social/@ianlake/112925099458782370

@yschimke yschimke merged commit db21f45 into google:main Aug 14, 2024
5 of 6 checks passed
@yschimke yschimke deleted the fix_publishing branch August 14, 2024 11:28
yschimke added a commit to yschimke/horologist that referenced this pull request Aug 20, 2024
yschimke added a commit that referenced this pull request Aug 20, 2024
* Reduce spacing between icon and title on Confirmation to 8dp (was 12dp)

BUG: 352551711

* Update Confirmation layout (#2327)

(cherry picked from commit 1ae64ea)

* Picker (#2330)

* Visual update for pickers.

Horizontal padding set to 5.2%
Padding above and below picker is 4.dp on smaller screens (less than 225.dp) and
6.dp on bigger screens.

---------

Co-authored-by: ssancho14 <ssancho14@users.noreply.github.com>
(cherry picked from commit c5f962a)

* Dialog 2: Dialog Harder (#2343)

* Update dialogs following validation.

Top & bottom padding to be percent based (14.56% and 20.83% respectively).
Add 4.dp extra below the Title if there is no message.

Bug: http://b/352552040

---------

Co-authored-by: ssancho14 <ssancho14@users.noreply.github.com>
Co-authored-by: Yuri Schimke <yuri@schimke.ee>

(cherry picked from commit 6c92d68)

* Update ReponsiveTimeText to 0dp, which simulates 2dp


* Cherry pick specific fixes from #2342

---------

Co-authored-by: stevebower <stevebower@google.com>
Co-authored-by: ssancho14 <50666481+ssancho14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants