Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::nullptr_t should be an acceptable ctor for all Scoped types. #274

Closed
jwhpryor opened this issue Mar 21, 2024 · 0 comments
Closed

std::nullptr_t should be an acceptable ctor for all Scoped types. #274

jwhpryor opened this issue Mar 21, 2024 · 0 comments
Assignees
@jwhpryor
Milestone
Release 1.1

Comments

@jwhpryor
Copy link
Collaborator

All types should support being initialized with nullptr but this appears to be inconsistent.

This behaviour is still supported through explicitly passing the tag type (e.g. jobject{nullptr} etc). But this should be a consolidated implementation.
@jwhpryor jwhpryor self-assigned this Mar 21, 2024
@jwhpryor jwhpryor added this to the Release 1.1 milestone Mar 21, 2024
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
d7d9c5c 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
@copybara-service copybara-service bot mentioned this issue Mar 21, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
6ba9a3a 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
4596628 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
7ed240d 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
4ade896 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
3d5a4da 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
copybara-service bot pushed a commit that referenced this issue Mar 21, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
f14d6da 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 617944956
copybara-service bot pushed a commit that referenced this issue Mar 22, 2024
@jwhpryor @copybara-github
Allow std::nullptr_t for all Scopable types (this was an oversight …
f7a9908 
…in the API).

In rare instances classes may want to have uninitialized members that reside on the stack. Previously, the base declaration will call the constructor with no arguments, but this API provides for declaring members with "LocalObject<kClass> obj{nullptr};" syntax.

#274

PiperOrigin-RevId: 618004432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwhpryor jwhpryor

Labels
None yet
Projects
None yet
Milestone
Release 1.1
Development

No branches or pull requests
1 participant
@jwhpryor