Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Field Tests for all types with multi-dimensions #40

Closed
jwhpryor opened this issue Feb 3, 2023 · 0 comments · Fixed by #226
Closed

E2E Field Tests for all types with multi-dimensions #40

jwhpryor opened this issue Feb 3, 2023 · 0 comments · Fixed by #226
Labels
enhancement New feature or request Release
Milestone
Release 1.0

Comments

@jwhpryor
Copy link
Collaborator

jwhpryor commented Feb 3, 2023

Only rank 0 fields are currently exercised, they should be exercised for all dimensions.
@jwhpryor jwhpryor added the enhancement New feature or request label Feb 3, 2023
@jwhpryor jwhpryor added this to the Release 1.0 milestone Feb 3, 2023
copybara-service bot pushed a commit that referenced this issue Nov 18, 2023
@jwhpryor @copybara-github
Split signature test into method and field.
5b7b734 
Field tests are under exercised for these signatures. While they're exercised indirectly elsewhere, it's helpful to have these tests for debugging.

Also, multi-dimensional field arrays aren't working (#40) so this ought help fix it.

PiperOrigin-RevId: 583658797
@copybara-service copybara-service bot mentioned this issue Nov 18, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Nov 18, 2023
@jwhpryor @copybara-github
Split signature test into method and field.
cde6d0e 
Field tests are under exercised for these signatures. While they're exercised indirectly elsewhere, it's helpful to have these tests for debugging.

Also, multi-dimensional field arrays aren't working (#40) so this ought help fix it.

PiperOrigin-RevId: 583658797
copybara-service bot pushed a commit that referenced this issue Nov 20, 2023
@jwhpryor @copybara-github
Split signature test into method and field.
3b672de 
Field tests are under exercised for these signatures. While they're exercised indirectly elsewhere, it's helpful to have these tests for debugging.

Also, multi-dimensional field arrays aren't working (#40) so this ought help fix it.

PiperOrigin-RevId: 583658797
copybara-service bot pushed a commit that referenced this issue Nov 20, 2023
@jwhpryor @copybara-github
Split signature test into method and field.
829989e 
Field tests are under exercised for these signatures. While they're exercised indirectly elsewhere, it's helpful to have these tests for debugging.

Also, multi-dimensional field arrays aren't working (#40) so this ought help fix it.

PiperOrigin-RevId: 584098520
copybara-service bot pushed a commit that referenced this issue Dec 3, 2023
@jwhpryor @copybara-github
Add rank 2 E2E tests for fields.
d4cdf8d 
This should resolve #40.

PiperOrigin-RevId: 585522598
@copybara-service copybara-service bot mentioned this issue Dec 3, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Dec 3, 2023
@jwhpryor @copybara-github
Add rank 2 E2E tests for fields.
88862f4 
This should resolve #40.

PiperOrigin-RevId: 585522598
copybara-service bot pushed a commit that referenced this issue Dec 3, 2023
@jwhpryor @copybara-github
Add rank 2 E2E tests for fields.
9438e55 
This should resolve #40.

PiperOrigin-RevId: 585522598
copybara-service bot pushed a commit that referenced this issue Dec 3, 2023
@jwhpryor @copybara-github
Add rank 2 E2E tests for fields.
97ebc8f 
This should resolve #40.

PiperOrigin-RevId: 585522598
copybara-service bot pushed a commit that referenced this issue Dec 3, 2023
@jwhpryor @copybara-github
Add rank 2 E2E tests for fields.
f10303d 
This should resolve #40.

PiperOrigin-RevId: 585522598
copybara-service bot pushed a commit that referenced this issue Dec 10, 2023
@jwhpryor @copybara-github
Add rank 2 E2E tests for fields.
908a658 
This should resolve #40.

PiperOrigin-RevId: 585522598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Release
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging a pull request may close this issue.

Add rank 2 E2E tests for fields. google/jni-bind
1 participant
@jwhpryor