CreateCopy is now the default for locals.
#210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_577476928
branch
10 times, most recently
from
5f48d19 to
8e8f56c
Compare
copybara-service
bot
force-pushed
the
test_577476928
branch
from
8e8f56c to
6033afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateCopyis now the default for locals.This follows from the discussion on #207.
Values passed through JNI are seemingly owned by the calling context and should not be deleted. This changes behaviour in existing applications, but at most should harmlessly leak a single local reference to a jobject.
This could be a break a breaking change if locally created JNI objects were being wrapped by a
LocalObjectin an inner loop, but can be obviated by usingAdoptLocalanywhere this is done.This also could break if you are passing nulls to objects (which is not allowed but would passively fail).
Because
LocalObject<kClass>{input_obj}is a "default path", this is going to become the default. All existing usages can addAdoptLocal{}to duplicate existing behaviour.