Add implementation/test for GlobalString destruction.
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_674322344
branch
2 times, most recently
from
efaba04 to
928524f
Compare
This was actually causing premature releases of `GlobalString` when directly constructed with arguments because it wasn't promoting its `LocalObject` after construction. Also, add tests for graceful destruction of GlobalObject which isn't returned. PiperOrigin-RevId: 674475063
copybara-service
bot
force-pushed
the
test_674322344
branch
from
928524f to
954558c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation/test for
GlobalStringdestruction.This was actually causing premature releases of
GlobalStringwhen directly constructed with arguments because it wasn't promoting itsLocalObjectafter construction.Also, add tests for graceful destruction of GlobalObject which isn't returned.