Fixing ambiguous equality operators for C++20 migration. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_688985785
branch
11 times, most recently
from
c2df16c to
7c283af
Compare
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.
e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
EXPECT_FALSE(val_1 == val_2);
~~~~~ ^ ~~~~~
```
See #346.
Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.
PiperOrigin-RevId: 689141602
copybara-service
bot
force-pushed
the
test_688985785
branch
from
7c283af to
e8b2c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing ambiguous equality operators for C++20 migration.
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.
e.g.
See #346.
Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.