Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand default green licenses #24

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Conversation

jinwoo
Copy link
Member

@jinwoo jinwoo commented Jan 10, 2018

Add most of 'reciprocal' and 'notice' level licenses.

@jinwoo jinwoo requested review from ofrobots and a team January 10, 2018 19:48
@jinwoo
Copy link
Member Author

jinwoo commented Jan 10, 2018

I removed problematic license IDs: TCP-wrappers, Unicode-DFS-2015, and Unicode-DFS-2016.

They make spdx-satisfies crash for an unclear reason. I filed an issue against spdx-satisfies: jslicense/spdx-satisfies.js#1

@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files           4        4           
  Lines         331      331           
  Branches       70       70           
=======================================
  Hits          270      270           
  Misses         61       61
Impacted Files Coverage Δ
ts/src/checker.ts 76.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f758b...cf720ca. Read the comment docs.

Add most of 'reciprocal' and 'notice' level licenses.
TCP-wrappers, Unicode-DFS-2015, and Unicode-DFS-2016.

They make `spdx-satisfies` crash for an unclear reason. I filed an issue
against spdx-satisfies:
jslicense/spdx-satisfies.js#1
@jinwoo
Copy link
Member Author

jinwoo commented Jan 16, 2018

Added a disclaimer to README.

@jinwoo
Copy link
Member Author

jinwoo commented Jan 17, 2018

PTAL

@jinwoo jinwoo merged commit 5a83c47 into google:master Jan 17, 2018
@jinwoo jinwoo deleted the new-licenses branch January 17, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants