Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of deprecated union operator #37

Closed
danfabi opened this issue May 29, 2019 · 2 comments
Closed

Usage of deprecated union operator #37

danfabi opened this issue May 29, 2019 · 2 comments

Comments

@danfabi
Copy link

danfabi commented May 29, 2019

Builds of elemental2 fail with Bazel 0.26.0 due to the usage of the deprecated "+" operator on depsets (see tracking issue bazelbuild/bazel#5817):

ERROR: /(...)/external/com_google_elemental2/java/elemental2/core/BUILD:38:1: in _jsinterop_generator rule @com_google_elemental2//java/elemental2/core:core__internal_src_generated: 
Traceback (most recent call last):
        File "/(...)/external/com_google_elemental2/java/elemental2/core/BUILD", line 38
                _jsinterop_generator(name = 'core__internal_src_generated')
        File "/(...)/external/com_google_jsinterop_generator/jsinterop_generator.bzl", line 124, in _jsinterop_generator_impl
                _get_generator_files(ctx.attr.deps)
        File "/(...)/external/com_google_jsinterop_generator/jsinterop_generator.bzl", line 49, in _get_generator_files
                transitive_srcs += target_provider.transitive_sources
`+` operator on a depset is forbidden. See https://docs.bazel.build/versions/master/skylark/depsets.html for recommendations. Use --incompatible_depset_union=false to temporarily disable this check.
@jDramaix
Copy link
Member

jDramaix commented Jun 7, 2019

Thanks! I have a cl in review internally that will fix this issue.

@jDramaix
Copy link
Member

jDramaix commented Jun 7, 2019

Need to rollback the cl

@jDramaix jDramaix reopened this Jun 7, 2019
jDramaix added a commit that referenced this issue Jun 7, 2019
@jDramaix @copybara-github
Roll forward of cl/252107530: Fix depset merge operations in jsintero…
24981b3 
…p-generator.

'+' operator on a depset is forbidden in Bazel 0.26

NEW: Flatten array of gwt modules names from deps.

*** Reason for rollback ***

Roll forward, fixing gwt module xml file generation

*** Original change description ***

Automated g4 rollback of changelist 252107530.

*** Reason for rollback ***

Break GWT targets using elemental

*** Original change description ***

Fix depset merge operations in jsinterop-generator.

'+' operator on a depset is forbidden in Bazel 0.26

Closes #37

***

PiperOrigin-RevId: 252127837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jDramaix @danfabi