Closed
Description
Analyzing the generated file in the examples (example.g.dart) I founded this piece of code:
Map<String, dynamic> _$PersonToJson(Person instance) {
final val = <String, dynamic>{
'firstName': instance.firstName,
};
void writeNotNull(String key, dynamic value) {
if (value != null) {
val[key] = value;
}
}
writeNotNull('middleName', instance.middleName);
val['lastName'] = instance.lastName;
val['date-of-birth'] = instance.dateOfBirth.toIso8601String();
val['last-order'] = instance.lastOrder?.toIso8601String();
val['orders'] = instance.orders; // HERE
return val;
}
Should Orders be assigned directly? Should they not be assigned iterating and converting to json?
Example:
Map<String, dynamic> _$PersonToJson(Person instance) {
final val = <String, dynamic>{
'firstName': instance.firstName,
};
void writeNotNull(String key, dynamic value) {
if (value != null) {
val[key] = value;
}
}
writeNotNull('middleName', instance.middleName);
val['lastName'] = instance.lastName;
val['date-of-birth'] = instance.dateOfBirth.toIso8601String();
val['last-order'] = instance.lastOrder?.toIso8601String();
val['orders'] = instance.orders?.map((i) => i.toJson())?.toList();
return val;
}
Metadata
Metadata
Assignees
Labels
No labels