Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added createJsonKeys #1401

Merged
merged 13 commits into from
Mar 3, 2024
Merged

Added createJsonKeys #1401

merged 13 commits into from
Mar 3, 2024

Conversation

ChreSyr
Copy link
Contributor

@ChreSyr ChreSyr commented Feb 20, 2024

See #1400

Copy link

google-cla bot commented Feb 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo
Copy link
Collaborator

kevmoo commented Feb 28, 2024

looks like you're missing a dependency override in json_serializable

@kevmoo
Copy link
Collaborator

kevmoo commented Mar 2, 2024

@ChreSyr – I landed some fixes – take a look!

@@ -1,6 +1,8 @@
## 4.8.2-wip

- Require Dart 3.0
- Added `JsonSerializable(createJsonKeys: true)`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 4.9.0 since we're adding new features!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto with json_serial. I'll do it. Just FYI for future.

@kevmoo kevmoo merged commit 5b46ef9 into google:master Mar 3, 2024
17 of 18 checks passed
}

typedef ModelJsonKeys = _$ModelJsonKeys;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart, i like the idea

Copy link

@Juliotati Juliotati Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChreSyr would be really nice to have this auto generated inside json_keys_example.g.dart above the generated ModelJsonKeys class

@ChreSyr
Copy link
Contributor Author

ChreSyr commented Mar 4, 2024

Thanks @kevmoo for your help and work ! It was my first experience in open-source contribution, I will definitely continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants