Skip to content

Include nullability information for generic class #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

Include nullability information for generic class #873

merged 1 commit into from
Apr 13, 2021

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Apr 13, 2021

Fixes #869

@kevmoo kevmoo requested a review from jakemac53 April 13, 2021 16:56
@kevmoo
Include nullability information for generic class
c7fff83 
Also allow nullable return values with fromJson if there is a default value

Fixes #869
@kevmoo kevmoo force-pushed the i869_missing_nullable_on_generic_class branch from 8b38682 to c7fff83 Compare April 13, 2021 21:29
@kevmoo kevmoo requested a review from natebosch April 13, 2021 22:32
natebosch
natebosch approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit message could use more detail about how the code changes in this diff accomplish the goal.

@kevmoo kevmoo merged commit 824950d into master Apr 13, 2021
@kevmoo kevmoo deleted the i869_missing_nullable_on_generic_class branch April 13, 2021 22:53
@kevmoo
Copy link
Collaborator Author

kevmoo commented Apr 13, 2021

@natebosch – good tip. I included more details when I hit the squash button!

@kevmoo kevmoo mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for nullable toJson, fromJson on a non-nullable field.
2 participants
@kevmoo @natebosch