Only recognize well-known comment markers #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colecf
force-pushed
the
robust_comments
branch
2 times, most recently
from
38e7d7c
to
6349d27
Compare
JeffFaer
reviewed
Oct 18, 2023
Colecf
force-pushed
the
robust_comments
branch
from
6349d27
to
70d3690
Compare
Restricting what comment markers keep-sorted accepts leads to less surprising behavior, such as // go/keep-sorted treating the comment marker as "// go/" when using the default id of just "keep-sorted".
Colecf
force-pushed
the
robust_comments
branch
from
70d3690
to
75c9f1f
Compare
JeffFaer
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricting what comment markers keep-sorted accepts leads to less surprising behavior, such as // go/keep-sorted treating the comment marker as "// go/" when using the default id of just "keep-sorted".