Stop panicking when trying to parse numbers bigger than 2^64. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffFaer
force-pushed
the
jfaer/big_int
branch
3 times, most recently
from
d58c0cc
to
d5c1ab7
Compare
JeffFaer
commented
Dec 15, 2023
Before: panic: mixedNumberPattern yielded an unparseable int: strconv.ParseInt: parsing "99999999999999999999999999999999999999999999999": value out of range
JeffFaer
force-pushed
the
jfaer/big_int
branch
from
d5c1ab7
to
820de56
Compare
KatrinaHoffert
approved these changes
Dec 18, 2023
JeffFaer
added a commit
that referenced
this pull request
Dec 18, 2023
This is what I get for not running the regression test before submitting #13. Before: `panic: mixedNumberPattern yielded an unparseable int: math/big: cannot unmarshal "09" into a *big.Int`
JeffFaer
added a commit
that referenced
this pull request
Dec 19, 2023
This is what I get for not running the regression test before submitting #13. Before: `panic: mixedNumberPattern yielded an unparseable int: math/big: cannot unmarshal "09" into a *big.Int`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
panic: mixedNumberPattern yielded an unparseable int: strconv.ParseInt: parsing "99999999999999999999999999999999999999999999999": value out of range