Allow for nested keep-sorted blocks. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffFaer
force-pushed
the
jfaer/nested
branch
3 times, most recently
from
6e6a64e
to
3a21cb9
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
from
3a21cb9
to
c45cd1c
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
2 times, most recently
from
afdc3fe
to
93f79a2
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
JeffFaer
force-pushed
the
jfaer/hanging_newline
branch
from
59563ff
to
1efce60
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
from
93f79a2
to
37c9db0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JeffFaer
commented
Dec 18, 2023
JeffFaer
force-pushed
the
jfaer/hanging_newline
branch
from
1efce60
to
348b776
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
from
37c9db0
to
3050f4a
Compare
JeffFaer
force-pushed
the
jfaer/hanging_newline
branch
2 times, most recently
from
80295df
to
e8f9471
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
12 times, most recently
from
ab8a948
to
4b780bc
Compare
KatrinaHoffert
previously approved these changes
Jan 3, 2024
JeffFaer
dismissed
KatrinaHoffert’s stale review
The base branch was changed.
JeffFaer
added a commit
that referenced
this pull request
Jan 12, 2024
…s the proper indent. (#15) This is necessary for a nested keep-sorted test case (#14) that uses group=yes to capture the nested keep-sorted blocks as well as newline_separated=yes in one of those nested blocks. Without this, the newlines that the nested block introduces break up the indent-based grouping, resulting in pretty bad behavior.
JeffFaer
force-pushed
the
jfaer/nested
branch
from
4b780bc
to
138f603
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
from
138f603
to
c15b5b2
Compare
JeffFaer
force-pushed
the
jfaer/nested
branch
from
c15b5b2
to
854dcea
Compare
KatrinaHoffert
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There's a couple different commits in this PR. The first commit contains a golden test that shows the behavior of keep-sorted before this PR.