Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Surface option parsing warnings via findings. #41

Merged
merged 5 commits into from
Sep 27, 2024
Merged

feat: Surface option parsing warnings via findings. #41

merged 5 commits into from
Sep 27, 2024

Commits on Sep 26, 2024

  1. feat: Surface option parsing warnings via findings. 

    These findings have no fix. I suppose we could recommend that they
remove the invalid text, but I think just surfacing the warning should
be enough. These show up as findings when linting and stderr warnings
when fixing.
    @JeffFaer
    JeffFaer committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7815f7d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Split expected stderr out into its own file 

    Also, get rid of timestamps so it's easier to compare the exact expected
stderr
    @JeffFaer
    JeffFaer committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1ee3169 View commit details
    Browse the repository at this point in the history

  2. Create findings directly in newBlocks. 

    Get rid of the optionWarnings type.
    @JeffFaer
    JeffFaer committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8c18ba0 View commit details
    Browse the repository at this point in the history

  3. nit: make spacing a bit more consistent in generate-goldens

    @JeffFaer
    JeffFaer committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d0ea4c7 View commit details
    Browse the repository at this point in the history

  4. Don't log the filename if it's stdin

    @JeffFaer
    JeffFaer committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8afdf9b View commit details
    Browse the repository at this point in the history